javascript - grunt-code-coverage-enforcer doesn't fail on threshhold limits -


i'm running jasmine tests , karma coverage generate lcov file. can see in coverage reports , console there poor line coverage on number of javascript files.

------------------------------------|-----------|-----------|-----------|-----------| file                                |   % stmts |% branches |   % funcs |   % lines | ------------------------------------|-----------|-----------|-----------|-----------|    ./src/accountdetails/controller\ |      9.09 |       100 |         0 |      9.09 |       accountdetailscontroller.js   |      9.09 |       100 |         0 |      9.09 |

istanbul isn't stopping grunt process, added grunt-code-coverage-enforcer. configuration looks this:

  'code-coverage-enforcer': { /* doesn't seem work either */     options: {       lcovfile: "build/lcov/phantomjs 1.9.7 (windows 7)/lcov.info",         lines: 99,         functions: 99,         branches: 99,         src: "src",         includes: ['src/**/*.js'],         excludes: []     }   }

i'm pretty sure enforcer running, because wasn't finding lcov.info file. if run enforcer task --verbose, see (removed lot of extraneous stuff, reiterates input options, correct):

reading lcov file .... processing file:build/lcov/phantomjs 1.9.7 (windows 7)/lcov.info checking if file exists ... build/lcov/phantomjs 1.9.7 (windows 7)/lcov.info processing callback [   {     "file": "./src/accountdetails/controller/accountdetailscontroller.js",     "lines": {       "found": 11,       "hit": 1     },     "functions": {       "hit": 0,       "found": 3     },     "branches": {       "hit": 0,       "found": 0     }   } ] ------------------------------------------------------------------ scanning folder files ------------------------------------------------------------------ collecting directory:src\accountdetails\controller ------------------------------------------------------------------ threshold configuration: lines:99%, functions:99%, branches:99% ------------------------------------------------------------------ file:./src/accountdetails/controller/accountdetailscontroller.js lines:9.09% | functions:100% | branches:100% | >> excluded done, without errors.

so questions are:

  • is correct?
  • what >> excluded in output about?
  • is enforcer task supposed fail build process?
  • can make fail build process (or misinterpreting code coverage enforcement in javascript app for) ????????????

i submitted pull request @ https://github.com/tapasvimoturu/grunt-code-coverage-enforcer/pull/2 should fix this. author accept request , republish project npm.


Comments

Post a Comment

Popular posts from this blog

javascript - RequestAnimationFrame not working when exiting fullscreen switching space on Safari -

request animation frame stops working when exiting fullscreen clicking on original space's safari window. fine if fullscreen mode canceled escape key or calling cancelfullscreen(). steps reproduce: open https://dl.dropboxusercontent.com/u/769042/prezi/safari-fullscreen.html click "draw raf", kittie appears click "fullscreen", go fullscreen click "draw raf", kittie appears go space original safari was, showing "click exit fullscreen mode", click anywhere, out fullscreen click "draw raf", nothing happens what handling click calling: window.requestanimationframe(draw); which draws on canvas context: function draw() { ctx.drawimage(img, math.random()*500|0, math.random()*400|0, 100, 100); } i checked .hidden , .visibilitystate, updated correctly. tested on osx 10.9.3, safari 7.0.4 (9537.76.4). has workaround/solution other switching old settimeout? this sounds webkit bug 88940 : using reque
Read more

Python ctypes access violation with const pointer arguments -

i have api i'm trying wrap in python (2.7.6 on win7) code using ctypes. here's api: client_dllfunc bool clientapi search_exporttoclipcopy(clienthsearch handle, int channel, lpctstr filename, const time_t& from, const time_t& to, const bool* cameras, int length, bool usepassword, lpctstr password, bool includetextin = false, bool excludeplayer = false); the issue i'm having cameras argument; , i've had issue other const pointer arguments well. here's how i'm wrapping api: def search_exporttoclipcopy(self, hsearch, csearch, filename, tfrom, tto, cameras, length, usepassword, password, includetextin=true, excludeplayer=false): exporttoclipcopy = self.sdkdll.search_exporttoclipcopy exporttoclipcopy.argtypes = [c_int, c_int, c_wchar_p, c_long, c_long, pointer(c_bool), c_int, c_bool, c_wchar_p, c_bool, c_bool] exporttoclipcopy.restype = c_bool exporttoclipcopy(hsearch, csearch, filename, tfrom, tto, cameras, length, usepassword, pass
Read more