rspec - Is calling the method I'm testing in a before block bad practice? - 


# first "should render china's jobs page country_name china"   'show', country: 'china'   expect(assigns(:title)).to eq("#{location.country} tech jobs")   expect(response).to be_success end  # second context "with country name"   before { 'show', country: 'china' }   { expect(assigns(:title)).to eq("#{location.country} tech jobs") }   { expect(response).to be_success } end

which 1 think better? prefer second 1 if before { 'show' } not bad practice.

i wouldn't it's bad practice, have downsides:

  • it's slower. in second case, it's got 2 examples, each of runs get 'show', country: 'china' -- can cause noticeable slowness when get 'show' slow.
  • it produces documentation output (to me @ least) doesn't describe behavior well. compare --format doc output 2 cases.
  • it makes harder add setup additional examples may add in future. consider if there's future case need test needs particular records inserted in db work properly. because action being tested (get 'show') in before block rather in example body, can't add additional setup 1 example needs it. (you can, of course, add additional setup before block itself, exacerbate slowness issue).

there benefits using before block. makes easy follow "one expectation per example" guideline. in turn give separate failing or passing examples assigns , response status expectations, can make more clear precisely failing, example.

which use depends on tradeoffs want make. tend towards first example (no before block).

on side note, if use latter form, i'd use specify alias (rather it) because use it when doc string or matcher reads english expression off of it:

specify { expect(assigns(:title)).to eq("#{location.country} tech jobs") } specify { expect(response).to be_success }

Comments

Post a Comment

Popular posts from this blog

javascript - RequestAnimationFrame not working when exiting fullscreen switching space on Safari -

request animation frame stops working when exiting fullscreen clicking on original space's safari window. fine if fullscreen mode canceled escape key or calling cancelfullscreen(). steps reproduce: open https://dl.dropboxusercontent.com/u/769042/prezi/safari-fullscreen.html click "draw raf", kittie appears click "fullscreen", go fullscreen click "draw raf", kittie appears go space original safari was, showing "click exit fullscreen mode", click anywhere, out fullscreen click "draw raf", nothing happens what handling click calling: window.requestanimationframe(draw); which draws on canvas context: function draw() { ctx.drawimage(img, math.random()*500|0, math.random()*400|0, 100, 100); } i checked .hidden , .visibilitystate, updated correctly. tested on osx 10.9.3, safari 7.0.4 (9537.76.4). has workaround/solution other switching old settimeout? this sounds webkit bug 88940 : using reque...
Read more

postgresql - how to get points from linestring postgis -

i have linestring (0 0 , 2 4 , 5 5); i need output in form : x (1st cell) || y (2nd cell) 0 || 0 2 || 4 5 || 5 and same polygon. how ? you can use st_x , st_y in conjunction st_pointn x , y of individual points, , use generate_series create index each point of linestring, eg, with line (select st_geomfromtext('linestring(0 0, 2 4, 5 5)') geom) select st_x(st_pointn(geom,num)) x, st_y(st_pointn(geom,num)) y line, (select generate_series(1, (select st_numpoints(geom) line)) num) series;
Read more

Why am I getting Internal .NET Framework Data Provider error 1025 when passing Method to where? -

i have method takes generic tentity overriden. it's signature follows: public virtual expression<func<aclproject, bool>> projectfilter(params tentity[] objs) { return (p) => objs.select(o => o.id).contains(p.id); } i filter query based on this: from p in db.somedbset db.aclprojects.where(projectfilter(p)).any() select p this results in 1025 error. (note doesn't matter body of projectfilter is, error still occurs. any ideas why? thanks!
Read more