ios - Is it better programming practice to test in a superclass if it is a subclass and then complete actions or to have those seperate -


specifically, have 2 different playingcardviewcontrollers have 2 different cardgames. both setcardgameviewcontroller , playingcardgameviewcontroller inherit general cardvc.

is better practice test in cardvc if class either of subclasses , complete actions needed each subclasses? mean there less code, seems might confusing. should best practice depend on how similar methods between 2 classes? asking reference using iskindofclass:

for example if ([self iskindofclass:[playingcardvc1 class]])

since asked more specific question here's more specific question. better put following method in subclass way i've defined , not implement in subclasses? or better practice set method in superclass cardvc nil, , implement separately in each of subclasses?

-(bool)inserthighscore:(highscore*)testedhighscore {  nsuserdefaults *defaults = [nsuserdefaults standarduserdefaults];  nsmutablearray *cardhighscores; // check if class setcardvc if ([self iskindofclass:[setcardgameviewcontroller class]]){     if (![defaults objectforkey:@"setcardhighscores"]){ // if nil         cardhighscores = [[nsmutablearray alloc]init];         [defaults setobject:cardhighscores forkey:@"setcardhighscores"];     }     cardhighscores = [defaults objectforkey:@"setcardhighscores"]; } // check if class playingcardvc else if([self iskindofclass:[playingcardgameviewcontroller class]]){     // ignored thing     if (![defaults objectforkey:@"playingcardhighscores"]){ // if nil         cardhighscores = [[nsmutablearray alloc]init];         [defaults setobject:cardhighscores forkey:@"playingcardhighscores"];     }     nslog(@"finding defaults count == %lu",(unsigned long)[(nsmutablearray *)[defaults objectforkey:@"playingcardhighscores"]count]);     cardhighscores = [defaults objectforkey:@"playingcardhighscores"]; } //... rest of code

tommy's solution one. here's alternative solution.

declare method in superclass take key parameter. call superclass method subclasses different keys. superclass implementation this

- (bool)inserthighscore:(highscore *)testedhighscore forkey:(nsstring *)key {     nsuserdefaults *defaults = [nsuserdefaults standarduserdefaults];      nsmutablearray *cardhighscores;      if (![defaults objectforkey:key]){         cardhighscores = [[nsmutablearray alloc]init];         [defaults setobject:cardhighscores forkey:key];     }     cardhighscores = [defaults objectforkey:key];      // ... rest of code }

the subclass implementation this

- (bool)inserthighscore:(highscore *)testedhighscore {     return [super inserthighscore:testedhighscore forkey:@"setcardhighscores"]; }

in general, code specific subclass goes in subclass implementation, code common subclasses goes superclass implementation, , can pass subclass-specific information superclass through parameters. in example above, superclass doesn't need know subclasses. knows subclasses give key in nsuserdefaults.


Comments

Post a Comment

Popular posts from this blog

javascript - RequestAnimationFrame not working when exiting fullscreen switching space on Safari -

request animation frame stops working when exiting fullscreen clicking on original space's safari window. fine if fullscreen mode canceled escape key or calling cancelfullscreen(). steps reproduce: open https://dl.dropboxusercontent.com/u/769042/prezi/safari-fullscreen.html click "draw raf", kittie appears click "fullscreen", go fullscreen click "draw raf", kittie appears go space original safari was, showing "click exit fullscreen mode", click anywhere, out fullscreen click "draw raf", nothing happens what handling click calling: window.requestanimationframe(draw); which draws on canvas context: function draw() { ctx.drawimage(img, math.random()*500|0, math.random()*400|0, 100, 100); } i checked .hidden , .visibilitystate, updated correctly. tested on osx 10.9.3, safari 7.0.4 (9537.76.4). has workaround/solution other switching old settimeout? this sounds webkit bug 88940 : using reque...
Read more

jsf - How to ajax update an item in the footer of a PrimeFaces dataTable? -

this visual of table have: +---------+------------+-------------------+ | header1 | header2 | header3 | +---------+------------+-------------------+ | row | input | calc'ed output | | row b | input b | calc'ed output b | | etc.. | etc.. | etc.. | +---------+------------+-------------------+ | total: total calc'ed output | +------------------------------------------+ and stripped-down code: <p:datatable id="mytable" value="#{mybean.somelist}" var="currentitem"> <p:column headertext="header1"> <h:outputtext value="#{currentitem.name}" /> </p:column> <p:column headertext="header2"> <pe:inputnumber value="#{currentitem.inputval}"> <p:ajax event="change" listener="#{mybean.changelistener}" update="outputval outputtotal...
Read more

django - CSRF verification failed. Request aborted. CSRF cookie not set -

error: reason given failure: csrf cookie not set. in general, can occur when there genuine cross site request forgery, or when django's csrf mechanism has not been used correctly. post forms, need ensure: browser accepting cookies. view function uses requestcontext template, instead of context. in template, there {% csrf_token %} template tag inside each post form targets internal url. if not using csrfviewmiddleware, must use csrf_protect on views use csrf_token template tag, accept post data. you're seeing section of page because have debug = true in django settings file. change false, , initial error message displayed. can customize page using csrf_failure_view setting. did find, nothing helped, must foolish(( my template <form method="post">{% csrf_token %} {% field in form %} <div class="control-group"> {{ field }} </div> {% endfor %} <input type=...
Read more