jquery and javascript toggle image tags between classes -


i can not seem right. please help. code supposed toggle class of img tag when user clicks on div.

here html

        <li><img src="img/gallery/val_day.jpg" id="img27" style="width: 100%;" alt="val_day" /></li>             </ul>           </div>             <p id="previouslink" href="#">«</p>         <p id="nextlink" href="#">»</p>         </div>

and here jquery , javascript.

$(document).ready(function () { var gallery = {     li: [''],     picnum: 0,     nextpic: function () {         $('#nextlink').click(function () {             var $activeimg = "'#img" + gallery.picnum + "'";             $($activeimg).toggleclass('activepic');             gallery.picnum++;             $activeimg = "'#img" + gallery.picnum + "'";             $($activeimg).toggleclass('activepic');          });     } }

});

the problems see how jquery selectors looking images.

remove apostrophes. example, change var $activeimg = "'#img" + gallery.picnum + "'"; to:

var $activeimg = "#img" + gallery.picnum.tostring();

the same thing should done second $activeimg.

my other comment on convention. convention, in experience, variable representing jquery object should prefixed $. $activeimg doesn't seem jquery object. it's string. use activeimageselector instead (a suggestion).

updated js

$(document).ready(function () {     var gallery = {         li: [''],         picnum: 0,         nextpic: function () {             $('#nextlink').click(function () {                 var activeimageselector  = "#img" + gallery.picnum.tostring();                 $(activeimageselector ).toggleclass('activepic');                 gallery.picnum++;                 activeimageselector  = "#img" + gallery.picnum.tostring();                 $(activeimageselector ).toggleclass('activepic');              });         }     } });

Comments

Post a Comment

Popular posts from this blog

javascript - RequestAnimationFrame not working when exiting fullscreen switching space on Safari -

request animation frame stops working when exiting fullscreen clicking on original space's safari window. fine if fullscreen mode canceled escape key or calling cancelfullscreen(). steps reproduce: open https://dl.dropboxusercontent.com/u/769042/prezi/safari-fullscreen.html click "draw raf", kittie appears click "fullscreen", go fullscreen click "draw raf", kittie appears go space original safari was, showing "click exit fullscreen mode", click anywhere, out fullscreen click "draw raf", nothing happens what handling click calling: window.requestanimationframe(draw); which draws on canvas context: function draw() { ctx.drawimage(img, math.random()*500|0, math.random()*400|0, 100, 100); } i checked .hidden , .visibilitystate, updated correctly. tested on osx 10.9.3, safari 7.0.4 (9537.76.4). has workaround/solution other switching old settimeout? this sounds webkit bug 88940 : using reque...
Read more

jsf - How to ajax update an item in the footer of a PrimeFaces dataTable? -

this visual of table have: +---------+------------+-------------------+ | header1 | header2 | header3 | +---------+------------+-------------------+ | row | input | calc'ed output | | row b | input b | calc'ed output b | | etc.. | etc.. | etc.. | +---------+------------+-------------------+ | total: total calc'ed output | +------------------------------------------+ and stripped-down code: <p:datatable id="mytable" value="#{mybean.somelist}" var="currentitem"> <p:column headertext="header1"> <h:outputtext value="#{currentitem.name}" /> </p:column> <p:column headertext="header2"> <pe:inputnumber value="#{currentitem.inputval}"> <p:ajax event="change" listener="#{mybean.changelistener}" update="outputval outputtotal...
Read more

django - CSRF verification failed. Request aborted. CSRF cookie not set -

error: reason given failure: csrf cookie not set. in general, can occur when there genuine cross site request forgery, or when django's csrf mechanism has not been used correctly. post forms, need ensure: browser accepting cookies. view function uses requestcontext template, instead of context. in template, there {% csrf_token %} template tag inside each post form targets internal url. if not using csrfviewmiddleware, must use csrf_protect on views use csrf_token template tag, accept post data. you're seeing section of page because have debug = true in django settings file. change false, , initial error message displayed. can customize page using csrf_failure_view setting. did find, nothing helped, must foolish(( my template <form method="post">{% csrf_token %} {% field in form %} <div class="control-group"> {{ field }} </div> {% endfor %} <input type=...
Read more